Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the git and metadata archive paths after the download is complete #1325

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

ArinGhazarian
Copy link
Collaborator

Closes https://github.ghe.com/github/octoshift/issues/9868

Description

This PR logs the git and metadata archive paths after their downloads are complete if the --keep-archive flag is passed.

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@Copilot Copilot bot review requested due to automatic review settings January 25, 2025 02:57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link

github-actions bot commented Jan 25, 2025

Unit Test Results

866 tests   866 ✅  21s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c4b2d5b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
Octoshift 87% 74% 1402
ado2gh 84% 78% 631
gei 81% 73% 596
bbs2gh 82% 76% 669
Summary 84% (7195 / 8539) 75% (1675 / 2234) 3298

Copy link
Member

@dpmex4527 dpmex4527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArinGhazarian ArinGhazarian merged commit b8b7890 into main Feb 3, 2025
30 checks passed
@ArinGhazarian ArinGhazarian deleted the log-downloaded-archive-path-in-gei-migrate-repo branch February 3, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants