Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning overwrites failing test results in test results pane #3386

Closed
rvermeulen opened this issue Feb 21, 2024 · 3 comments · Fixed by #3413
Closed

Compiler warning overwrites failing test results in test results pane #3386

rvermeulen opened this issue Feb 21, 2024 · 3 comments · Fixed by #3413
Labels
bug Something isn't working VSCode

Comments

@rvermeulen
Copy link

Describe the bug

When you execute a QL test from the test explorer, and the compilation of the tested query has warnings, such as unused predicates or deprecated elements, then the diff view of a failed test is not visible.

Version
The CodeQL and VS Code version in which the bug occurs.

CodeQL extension version: 1.12.2
CodeQL CLI version: 2.14.6
Platform: darwin x64

To reproduce

  1. Create a failing QL test of a query with an unused predicate or deprecated module.
  2. Execute the test

Expected behavior

The test explorer shows the diff of the expected and actual output, in addition to the compiler warnings.

@rvermeulen rvermeulen added the bug Something isn't working label Feb 21, 2024
@MathiasVP
Copy link
Contributor

FWIW, I've also heard Microsoft people mention this before

@starcke
Copy link
Contributor

starcke commented Feb 26, 2024

Thanks for the report. I have opened a ticket internally to track this.

@koesie10
Copy link
Member

This will be fixed in the next release of the extension. Please note that the compiler warning will still show up in the test output as this functionality is used for testing CodeQL itself as well:

Screenshot 2024-02-28 at 10 48 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants