Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show test results for tests with warnings #3413

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Feb 28, 2024

This fixes tests with warnings that would error out instead of showing the diff. It now results in:

Screenshot 2024-02-28 at 10 48 48

The warning being shown in the actual output is expected and is part of normal testing of CodeQL. I don't think that's something that can be changed.

Closes #3386

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review February 28, 2024 10:20
@koesie10 koesie10 requested a review from a team as a code owner February 28, 2024 10:20
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Optional: can we add any tests around this, or is the area not generally covered by tests?

@koesie10
Copy link
Member Author

Optional: can we add any tests around this, or is the area not generally covered by tests?

There aren't many tests for this area, but I've added a test for this specific behavior to the existing test.

@koesie10 koesie10 merged commit f73ea67 into main Feb 28, 2024
30 checks passed
@koesie10 koesie10 deleted the koesie10/fix-tests-with-warnings branch February 28, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warning overwrites failing test results in test results pane
2 participants