Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: devtools context menu #1324

Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat: devtools context menu #1324

merged 5 commits into from
Jul 2, 2024

Conversation

afonsojramos
Copy link
Member

@afonsojramos afonsojramos commented Jul 1, 2024 •
edited
Loading

I'd argue the "old" settings were not really useful, so I've also removed them.

setchy
setchy reviewed Jul 1, 2024
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
setchy
setchy requested changes Jul 1, 2024
View reviewed changes
src/electron/main.js Outdated Show resolved Hide resolved
src/electron/main.js Outdated Show resolved Hide resolved
@afonsojramos afonsojramos requested a review from setchy July 2, 2024 00:38
setchy
setchy approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@setchy setchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to only show the dev context menu items (reload, toggledevtools) if running locally, but otherwise lgtm!

@afonsojramos
Copy link
Member Author

We're all developers here, so why not 🤠 Maybe it sparks interest in someone contributing 🤞

@afonsojramos afonsojramos merged commit 81e027e into main Jul 2, 2024
8 checks passed
@afonsojramos afonsojramos deleted the chore/improve-dev-exp branch July 2, 2024 19:05
@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jul 6, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jul 6, 2024
@setchy setchy changed the title chore: automatically open devtools on local development feat: devtools context menu Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setchy setchy setchy approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@afonsojramos @setchy