Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global click handler for cmd+ctrl click background launching #1382

Closed
wants to merge 7 commits into from

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 16, 2024

Supersedes #1366

Pending:

  • updating unit tests
  • clean up any stray event.stopPropogation()

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jul 16, 2024
@setchy
Copy link
Member Author

setchy commented Jul 20, 2024

@afonsojramos @bmulholland how do you both feel about the direction this PR is heading in?

@setchy
Copy link
Member Author

setchy commented Aug 6, 2024

Based on discussions with @bmulholland - we feel that the recently added System Setting for open link preferences (foreground, background) is sufficient at this time.

Closing this PR for now

@setchy setchy closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant