Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buildkit and go #72

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update buildkit and go #72

wants to merge 2 commits into from

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Aug 8, 2023 •
edited
Loading

  • buildkit to v0.12.4
  • go to 1.20
  • build.go the signature for progressui.DisplaySolveStatus changed
  • combiner.go Architecture and OS were removed from the image spec

Must

  • consider replacing rice with embed, we're presently failing with runner binary is too big (> gRPC message size)

Could

@kylos101 kylos101 changed the title Update dep Update deps Aug 8, 2023
kylos101
kylos101 commented Aug 8, 2023
View reviewed changes
Copy link
Contributor Author

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief self-review

pkg/dazzle/combiner.go Show resolved Hide resolved
@kylos101 kylos101 marked this pull request as ready for review August 8, 2023 17:40
@kylos101 kylos101 requested a review from a team as a code owner August 8, 2023 17:40
@kylos101 kylos101 changed the title Update deps Update buildkit and go Aug 8, 2023
@kylos101 kylos101 marked this pull request as draft August 8, 2023 18:13
@kylos101 kylos101 removed the request for review from a team August 8, 2023 18:23
@kylos101 kylos101 force-pushed the kylos101/update-deps branch from 8f90da3 to a2b54c8 Compare December 12, 2023 22:19
@kylos101
Update dep
b4b4b6a 
* buildkit to v0.12.1
* go to 1.20
* `build.go` the signature for `progressui.DisplaySolveStatus` changed
* `combiner.go` Architecture and OS were removed from the image spec
@kylos101
Update buildkit
476277b
@kylos101 kylos101 force-pushed the kylos101/update-deps branch from c3aa827 to 476277b Compare December 12, 2023 23:40
@kylos101 kylos101 mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylos101