-
Notifications
You must be signed in to change notification settings - Fork 75
Fixes #53 fix the broken link. #54
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, many thanks @nisarhassan12!
I made two suggestions in-line.
README.md
Outdated
@@ -5,7 +5,7 @@ This repository contains externally maintained `.gitpod` files for projects on G | |||
|
|||
The files are organized by repository name. If you need a different configuration for a fork the repository folder can contain a folder for the organisation. | |||
|
|||
The configuration format is explained [here](https://docs.gitpod.io/40_Configuration.html#gitpod-file). | |||
The configuration format is explained [here](https://www.gitpod.io/docs/configuration/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! But actually, re-reading this sentence, I don't think that the configuration format is explained in https://www.gitpod.io/docs/configuration/ (that page seems to be more about the Setup Assistant / the general configuration process, as opposed to the specific .gitpod.yml
format).
Maybe linking to https://www.gitpod.io/docs/config-gitpod-file/ would be more relevant / helpful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I notice that the paragraph above talks about a .gitpod
file. I think this is outdated information, because this file is now called .gitpod.yml
. 😄 Could you please fix it as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have fixed it 🙂
Hi, i was trying to find a comprehensive list of settings configurable in the |
@@ -1,11 +1,11 @@ | |||
# External Gitpod Configuration | |||
|
|||
[Gitpod](https://gitpod.io) is an online IDE for GitHub. | |||
This repository contains externally maintained `.gitpod` files for projects on GitHub. | |||
This repository contains externally maintained `.gitpod.yml` files for projects on GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jankeromnes Are we gonna have separate definitely-gp repos for other platforms like GitLab
and Bitbucket
?
|
Fixes #53