[dashboard] Fix Arc favourites #20466
Conversation
| @@ -458,11 +463,17 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps, | |||
| } | |||
|
|
|||
| redirectTo(url: string) { | |||
| if (this.state.redirected) { | |||
There was a problem hiding this comment.
Nice!
🫧 What are situations where we need to reset this value? 🤔
There was a problem hiding this comment.
Good question: I'd say it's enough when React resets it when the page unmounts. On the page level, this prop should be permanent (or at least I don't see reasons why we'd forget about having redirected you somewhere).
|
@filiptronicek Can you re-deploy the preview pls? 🙏 |
|
@geropl aaah, it just broke. Let me deploy it now... |
|
should be up again: https://ft-fix-arc-redirects.preview.gitpod-dev.com/workspaces |
|
@filiptronicek I noted that I see the alert for a second before I'm effectively redirect. Not super important, but it talks about "probably opened in a new tab", while it gets replaced by the new content right after - which is a bit confusing. Any ideas on how to avoid that? 🤔 |
Great catch, I couldn't reproduce this myself but makes sense that it happens. I'm thinking of adding an additional prop that will trigger 2 seconds after we redirect, so that it's not there even before the UA gets the chance to properly redirect you. |
|
We'll be merging this one after the New Year. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
meta: stale
|
Hey @filiptronicek, happy new year! 🎉 Can we merge this now? |
|
@axonasif HNY to you, too! The PR is missing a review currently, but maybe @geropl can help with that :). I've just re-deployed the preview environment and am happy to pair on this if you want. |
| this.setState({ redirected: true }); | ||
| setTimeout(() => { | ||
| this.setState({ showRedirectMessage: true }); | ||
| }, 2000); |
There was a problem hiding this comment.
2s might be a tad too short, but let's see. Worked for me right now. 👍
There was a problem hiding this comment.
Wanted to find a threshold which was not too short to prevent races, but also not too long to actually show up in time to be useful to the user. Will leave as is for now
Description
There's a funny bug that happened when you favorited the Gitpod Dashboard in Arc: when you open a favorited website, it does not want you to leave its origin and upon redirection to another one opens it in a new tab. This would be cool with us if we didn't try to redirect you on every workspace status update (spoiler alert: we do).
This PR stores a
redirectedproperty in the React state and prevents multiple redirects from happening. There's also a tiny piece of UI that tells you what happened if you end up back in the favorited tab, with buttons to more easily retry or get back to the dashboard.Related Issue(s)
Fixes CLC-820
How to test
/hold