[wip] [AB-0004]: extract svg files #370
Conversation
|
@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return <OrderInProgress group={message?.id!} buyer={isBuyer} order={message?.orders[0]?.id!} />; | ||
| return ( | ||
| <OrderInProgress | ||
| group={message?.id!} |
Check warning
Code scanning / ESLint
Disallow non-null assertions using the `!` postfix operator Warning
| <OrderInProgress | ||
| group={message?.id!} | ||
| buyer={isBuyer} | ||
| order={message?.orders[0]?.id!} |
Check warning
Code scanning / ESLint
Disallow non-null assertions using the `!` postfix operator Warning
OleksandrKucherenko
changed the title
|
Nice work! testing it! |
|
Started to check it, I already see some problem in the login |
it's not done... Work In Progress |
OleksandrKucherenko
force-pushed
the
AB0004-extract-svg-files
branch
2 times, most recently
from
dc0af24
to
94fb1c5
Compare
OleksandrKucherenko
force-pushed
the
AB0004-extract-svg-files
branch
from
94fb1c5
to
a4c24b6
Compare
|
Hi @OleksandrKucherenko Did you manage to check it? |
Nope, does not have a free time for that. Compilation is passed and locally it works. |
|
Converting this to draft as this is WIP. A compile is not a good test of this one, really it's going to require visually going around and checking as many of the pages by eye as possible, as it's likely to introduce lots of tricky little subtle visual issues. This is a really good positive change though. |
What kind of change does this PR introduce?
Code improvement, extracting SVGs into own files.
Why was this change needed?
Extract assets into own files.
Other information:
#369
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;