Fix: Error handling #386
Open
Fix: Error handling #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bilalmirza74 is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
|
@jamesread Take a look |
jamesread
reviewed
Oct 22, 2024
| .utc(post.publishDate) | ||
| .diff(dayjs.utc(post.publishDate).startOf('day'), 'minute'), | ||
| })); | ||
| const createdPosts = posts.map((post) => { |
There was a problem hiding this comment.
Under what condition is post.integration null? I don't know if just just using the null operator on everything below is the right approach here, it feels like post.integration = null is an error?
There was a problem hiding this comment.
Yes
post.integration could be null if there's missing or invalid integration data linked to posts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
error handling component by checking for missing integrations before accessing their properties
eg: Bug fix, feature, docs update, ...
Why was this change needed?
Please link to related issues when possible, and explain WHY you changed things, not WHAT you changed.
Other information:
eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;