Merge pull request #114 from chunkerchunker/master

bugfix: passing Date proxy to Date constructor
giusepperaso · Jul 14, 2024 · ec0a72d · ec0a72d
2 parents ecc4b86 + 0d6dc1a
commit ec0a72d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/proxy/proxyHandler.ts b/src/proxy/proxyHandler.ts
@@ -166,7 +166,10 @@ export class CreateProxyHandler {
     }
     if (type === Types.Date) {
       if (typeof v === Types.function) {
-        if ((p as string).indexOf(Methods.set) === 0) {
+        if ((p !== Symbol.toPrimitive) && (
+          (typeof p === 'symbol' && Symbol.keyFor(p)?.indexOf(Methods.set) === 0) ||
+          ((p as string).indexOf(Methods.set) === 0)
+        )) {
           return function (...args: unknown[]) {
             walkParents(state, Actions.set_date, data, pStore, t, p, args);
             return r;

diff --git a/src/tests/integration/basics.test.ts b/src/tests/integration/basics.test.ts
@@ -138,6 +138,8 @@ runMultiple("tests all(most) of the basic types", () => {
     const result = produce(myDate, (draft) => {
       draft.a.setSeconds(draft.a.getSeconds() + 1);
       draft.a.setSeconds(draft.a.getSeconds() + 1);
+
+      expect((new Date(draft.a)).toString()).toBe(draft.a.toString()); // compare to the second, since the constructor will drop milliseconds
     });
 
     expect(myDate.a.getTime()).not.toBe(result.a.getTime());