Enhancements to AST traversal #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pruning on definition nodes * pruning on statement nodes * early exit list, block and tuple expressions
lpil
reviewed
Apr 10, 2024
|
I provided some additional comments to the code and removed the cov_mark tool. |
* pruning on definition nodes * pruning on statement nodes * early exit list, block and tuple expressions
lpil
reviewed
Apr 17, 2024
compiler-core/src/ast/tests.rs
Outdated
| #[test] | ||
| fn find_node_sequence_early_exit() { | ||
| let block = compile_expression(r#"{ 1 2 3 }"#); | ||
| assert!(block.find_node(1).is_none()); |
There was a problem hiding this comment.
Removed the test, but it should not return the block, as the test find_node_sequence() shows.
|
Could you rebase on main to remove the merge conflict please 🙏 |
|
I am not really sure how to fix this failing check, sorry. |
|
Oh yeah there was a vulnerability that apparently was surfaced today. you can fix by running |
|
34864ed i had to make the same change here to get things working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of my earlier PR on providing pipeline suggestions through the Gleam LSP.
I identified some potential enhancements to the Gleam AST traversal algorithm, and as a result, I made the following changes:
I believe these enhancements will contribute to the overall effectiveness and efficiency of the pipeline suggestion feature.
I welcome any feedback or suggestions for improvement. 😃