Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Erlang code generation for floating point numbers #3075

Merged
merged 5 commits into from
May 3, 2024
Merged

Fix Erlang code generation for floating point numbers #3075

merged 5 commits into from
May 3, 2024

Conversation

giacomocavalieri
Copy link
Member

This PR fixes #3073

@lpil
Copy link
Member

lpil commented May 1, 2024

Snaps need to be updated!

@giacomocavalieri
Copy link
Member Author

Oops, fixed!

@giacomocavalieri giacomocavalieri mentioned this pull request May 3, 2024
Merged
@giacomocavalieri
fix-3073
1dd1194
@giacomocavalieri
update snapshots!
684fe2f
@giacomocavalieri
Lints!
d5b4c34 
I disabled dead code for a couple of traits as Louis suggested.
I also removed the one complaining about documentation because it would report loads of false positives.
All other lints are fixed.
@giacomocavalieri
address review comments
588f058
lpil
lpil approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit ed97490 into gleam-lang:main May 3, 2024
11 checks passed
@giacomocavalieri giacomocavalieri deleted the fix-3073 branch May 3, 2024 10:24
@giacomocavalieri giacomocavalieri mentioned this pull request May 3, 2024
Closed
@hamirmahal hamirmahal mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper Erlang Codegen of Scientific Notation Floats without Trailing Zeros
2 participants
@giacomocavalieri @lpil