Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing CI check #67

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: failing CI check #67

merged 1 commit into from
Apr 3, 2024

Conversation

hamirmahal
Copy link
Contributor

fixes #66.

@hamirmahal
Copy link
Contributor Author

@lpil can you make it so that contributors can see which checks are passing and failing in a pull request?

It doesn't show anything in my view.

image

@hamirmahal
Copy link
Contributor Author

https://github.com/gleam-lang / gleam does this.

image

That's from gleam-lang/gleam#2879.

@lpil
Copy link
Member

lpil commented Apr 3, 2024

I don't know why it looks like that, I'm not aware of any such config

lpil
lpil approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lpil lpil merged commit bdad5b7 into gleam-lang:main Apr 3, 2024
@hamirmahal
Copy link
Contributor Author

You're welcome!

@hamirmahal hamirmahal deleted the fix/failing-ci-check branch April 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI / test (push) Failing after 3s
2 participants
@hamirmahal @lpil