PR change : removed array usage for emiting , added local function to…

… ensure single addition of "System.Collections.Generic"
glideapps · Jun 8, 2024 · 0f67311 · 0f67311
1 parent 9c7467c
commit 0f67311
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/packages/quicktype-core/src/language/CSharp/CSharpRenderer.ts b/packages/quicktype-core/src/language/CSharp/CSharpRenderer.ts
@@ -389,19 +389,23 @@ export class CSharpRenderer extends ConvenienceRenderer {
     }
 
     protected emitDependencyUsings(): void {
-        let nameSpaceForTypes: string[] = [];
+        let genericEmited: boolean = false;
+        let ensureGenericOnce = () => {
+            if (!genericEmited) {
+                this.emitUsing("System.Collections.Generic");
+                genericEmited = true;
+            }
+        }
         this.typeGraph.allTypesUnordered().forEach(_ => {
             matchCompoundType(
                 _,
-                _arrayType => this._csOptions.useList ? nameSpaceForTypes.push("System.Collections.Generic") : undefined,
+                _arrayType => this._csOptions.useList ? ensureGenericOnce() : undefined,
                 _classType => { },
-                _mapType => nameSpaceForTypes.push("System.Collections.Generic"),
+                _mapType => ensureGenericOnce(),
                 _objectType => { },
                 _unionType => { }
             )
         });
-        nameSpaceForTypes = nameSpaceForTypes.filter((val, ind) => nameSpaceForTypes.indexOf(val) === ind );
-        nameSpaceForTypes.forEach(this.emitUsing.bind(this));
     }
 
 }