-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ESLint fixes #2558
Merged
dvdsgl
merged 42 commits into
glideapps:master
from
inferrinizzard:chore/repo/eslint-fix
May 12, 2024
Merged
chore: ESLint fixes #2558
dvdsgl
merged 42 commits into
glideapps:master
from
inferrinizzard:chore/repo/eslint-fix
May 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! fix enum values
fixup! add all missing accessibility modifiers fixup! add all missing accessibility modifiers
fixup! fix any types fixup! fix any types
dvdsgl
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes all outstanding ESLint issues as reported in #2555
Motivation and Context
Once #2555 is merged, the latest commit on the master branch will be in an unstable state. This PR aims to immediately resolve that by fixing all existing errors including:
any
typeThis PR also tags several sections of the codebase that are in need of a refactor, these are the major candidates:
a. This file is far too heavily nested and dense to easily grok
a. There are ~5 major circular import cycles that need to be resolved
a. strongly typing RendererOptions (as well as a few other places) could help to alleviate some areas where types are currently unknown/unclear
b. would additionally help users of
quicktype-core
as we could provide intellisense while writing optionsPrevious Behaviour / Output
N/a
New Behaviour / Output
N/a
How Has This Been Tested?
npm run lint
now only comes back with warnings, no errorsScreenshots (if appropriate):