too many arguments in call to r.DecodeBytes #592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcuslinke
pushed a commit
to marcuslinke/registrator
that referenced
this pull request
Sep 30, 2017
maskshell
approved these changes
Jan 17, 2018
maskshell
suggested changes
Jan 17, 2018
There was a problem hiding this comment.
Still have errors
# github.com/coreos/go-etcd/etcd
../../coreos/go-etcd/etcd/response.generated.go:846: cannot use x.Expiration (type *time.Time) as type time.Time in argument to r.encDriver.EncodeTime
../../coreos/go-etcd/etcd/response.generated.go:866: cannot use x.Expiration (type *time.Time) as type time.Time in argument to r.encDriver.EncodeTime
|
This is fixed by a recent change to pin dependencies via |
marcuslinke
pushed a commit
to marcuslinke/registrator
that referenced
this pull request
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-etcd is depricated, so will not receive fixes required to compile with recent breaking changes in ugorji/go
re :
#591
coreos/go-etcd#250