Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyproject.toml tools -> tool. #1020

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix pyproject.toml tools -> tool. #1020

merged 2 commits into from
Feb 5, 2025

Conversation

bdice
Copy link
Member

@bdice bdice commented Feb 5, 2025

Description

There is a typo in pyproject.toml. It should be [tool.setuptools...] instead of [tools.setuptools...].

A warning is issued when building (observed with Python 3.12 and pip 25.0):

/tmp/build-env-vzednt84/lib/python3.12/site-packages/setuptools/config/pyprojecttoml.py:72: _ToolsTypoInMetadata: Ignoring [tools.setuptools] in pyproject.toml, did you mean [tool.setuptools]?

Checklist:

@bdice bdice requested review from a team as code owners February 5, 2025 12:37
@bdice bdice requested review from b-butler and SchoeniPhlippsn and removed request for a team February 5, 2025 12:37
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (4db7429) to head (27c13ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          20       20           
  Lines        3503     3503           
  Branches      662      662           
=======================================
  Hits         3021     3021           
  Misses        331      331           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaander joaander merged commit aa4968a into main Feb 5, 2025
16 checks passed
@joaander joaander deleted the fix-pyproject branch February 5, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants