Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define build command in asv.conf.json to enable support for asv 0.6.2 and later #1021

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

bdice
Copy link
Member

@bdice bdice commented Feb 11, 2025

Description

asv 0.6.2 and later changed the default build command, breaking our benchmarks.

This PR defines a build_command that appears to work, which is closer to the pre-0.6.2 behavior of asv.

Motivation and Context

See #1017 (comment) and airspeed-velocity/asv#1453 (comment).

Checklist:

@bdice bdice requested review from a team as code owners February 11, 2025 00:35
@bdice bdice requested review from cbkerr and shihkual and removed request for a team February 11, 2025 00:35
@bdice
Copy link
Member Author

bdice commented Feb 11, 2025

@janbridley Would you be able to test this PR?

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (aa4968a) to head (1e0ae60).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          20       20           
  Lines        3503     3503           
  Branches      662      662           
=======================================
  Hits         3021     3021           
  Misses        331      331           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janbridley
Copy link

Everything appears to be working on asv==0.6.4 with a pure python (no conda/micromamba) install. With a micromamba environment, I am still observing intermittent timeouts. It might be useful to set up a CI runner for the benchmarks? This could be paired with something like the validate label HOOMD uses for long-running test, and would standardize the benchmark environment to prevent future confusion.

@joaander
Copy link
Member

We have dedicated CPU runners on Jetstream2 that could run the benchmarks with a consistent amount of overhead.

@bdice
Copy link
Member Author

bdice commented Feb 11, 2025

Thanks. I'll leave the decisions to you about whether to run benchmarks regularly -- could one of you approve the PR and merge if you're okay with its current state?

@janbridley janbridley enabled auto-merge (squash) February 11, 2025 18:38
@janbridley
Copy link

I do not have merge permissions but this LGTM.

@bdice bdice disabled auto-merge February 11, 2025 20:20
@bdice bdice merged commit ff736a2 into main Feb 11, 2025
16 checks passed
@bdice bdice deleted the support-asv-0.6.2 branch February 11, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants