-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define build command in asv.conf.json to enable support for asv 0.6.2 and later #1021
Conversation
@janbridley Would you be able to test this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 86.24% 86.24%
=======================================
Files 20 20
Lines 3503 3503
Branches 662 662
=======================================
Hits 3021 3021
Misses 331 331
Partials 151 151 ☔ View full report in Codecov by Sentry. |
Everything appears to be working on |
We have dedicated CPU runners on Jetstream2 that could run the benchmarks with a consistent amount of overhead. |
Thanks. I'll leave the decisions to you about whether to run benchmarks regularly -- could one of you approve the PR and merge if you're okay with its current state? |
I do not have merge permissions but this LGTM. |
Description
asv
0.6.2 and later changed the default build command, breaking our benchmarks.This PR defines a
build_command
that appears to work, which is closer to the pre-0.6.2 behavior ofasv
.Motivation and Context
See #1017 (comment) and airspeed-velocity/asv#1453 (comment).
Checklist: