-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic search/list controller #18052
Generic search/list controller #18052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This controller will probably be common to not only assets but most of the CommonDBTM
classes. The technical names should not contains asset. Also, it could be considered as an index
controller for the corresponding class.
Glpi\Controller\Asset\CommonAssetController
->Glpi\Controller\CommonIndexController
(or maybeGenericIndexController
)/asset/{type}/search
->/{type}
getAssetClass()
->getClass()
Instead of "index" I suggest using the term "Model", because that's both self-explanatory and generic, wdyt? We would then have "Model list", and "Model form", for routes and controllers naming |
|
8995174
to
5915e5d
Compare
0c4185e
to
c581873
Compare
For now, forms are not handled because they're much more complex. Almost all standard cases are handled by this PR 👌 |
2b0fa27
to
7a829b4
Compare
Quality Gate failedFailed conditions |
e6e778d
to
548e0a6
Compare
fab635d
to
d568a3d
Compare
No description provided.