Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to make schema validation more flexible #151

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Add method to make schema validation more flexible #151

merged 3 commits into from
Jan 21, 2025

Conversation

trasher
Copy link
Collaborator

@trasher trasher commented Jan 21, 2025

Add method to make schema validation more flexible (allowing additional properties in content and all child nodes). This is the first commit.

Also:

  • create a Schema class instead of doing everything in Converter
  • use Schema version (bumped to 1.0) from schema file instead of duplicating in PHP class

Can be reviewed per commit

cedric-anne
cedric-anne approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

@trasher trasher merged commit 0dcfdf1 into main Jan 21, 2025
12 checks passed
@trasher trasher deleted the feature/additional_properties branch January 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trasher @stonebuzz @cedric-anne