Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for glue-qt #42

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Updates for glue-qt #42

merged 5 commits into from
Aug 18, 2023

Conversation

Carifio24
Copy link
Member

This PR updates this package to be compatible with the new glue-qt package (see glue-viz/glue#2431).

@Carifio24 Carifio24 marked this pull request as draft August 18, 2023 05:51
@Carifio24
Copy link
Member Author

Carifio24 commented Aug 18, 2023

Not sure yet what's causing the segfaults (!) in the image test. I see them running the tox environments locally as well, but actually using the image exporter from glue is working fine (it was working fine with some changes I had forgotten to commit!).

@Carifio24 Carifio24 marked this pull request as ready for review August 18, 2023 19:39
@Carifio24 Carifio24 merged commit 9ea4dfc into glue-viz:main Aug 18, 2023
18 checks passed
@Carifio24 Carifio24 added the Qt label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant