Updates to z-order manipulation #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up some issues with z-order manipulation that were noticed while using the scatter viewer in CosmicDS. Note that many of the changes here were based on the behavior of the bqplot scatter viewer.
Additionally, the viewers now retain other marks (e.g. those made by tools) when reordering the layers. Since there's no sensible general way to order these sorts of traces, they all just get push to the end of the trace list (higher z-index). If the tool that created these traces needs them in a particular order, it will have to sort that out itself. Note that the ordering of these non-glue traces relative to each other is left untouched.