Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 and 3.12 CI envs #91

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Conversation

dhomeier
Copy link
Contributor

Description

For good measure testing this with 3.11.0 as well.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (9d482be) to head (44eae90).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files          18       18           
  Lines        1023     1023           
=======================================
  Hits          707      707           
  Misses        316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhomeier
Copy link
Contributor Author

Upstream action on reproject and pywwt required; reproject might just need re-cythonising, no idea about pywwt.

@astrofrog
Copy link
Member

reproject is a WIP

@dhomeier
Copy link
Contributor Author

Yes; installing git+https://github.com/astropy/reproject.git works now.

@dhomeier
Copy link
Contributor Author

dhomeier commented Mar 4, 2023

pywwt and reproject updates have been released, so 3.11 can also be tested in normal envs now.
I have removed the win-py37 run, which has started to fail on a Windows path error.
@astrofrog I just noticed you are already dropping support for 3.7 in #94 – should I sync with that?

There are strange failures with the development version of glue-core, throwing errors like

../../.tox/py39-test-devdeps/lib/python3.9/site-packages/glue/app/qt/feedback.py:10: in
from glue._deps import get_status_as_odict
../../.tox/py39-test-devdeps/lib/python3.9/site-packages/glue/_deps.py:227: in
('plugins', plugins()),
../../.tox/py39-test-devdeps/lib/python3.9/site-packages/glue/_deps.py:217: in plugins
package = entry_point.dist.name
E AttributeError: 'EntryPoint' object has no attribute 'dist'

e.g. https://github.com/glue-viz/glue-wwt/actions/runs/4331625068/jobs/7563583949#step:9:156

all 3.8 and 3.9 platforms, although glue's own tests are obviously still passing on 3.8.

@astrofrog
Copy link
Member

@dhomeier - can you rebase/update this? Thanks!

@dhomeier
Copy link
Contributor Author

@astrofrog, done. Should py312 be added now as well?

@astrofrog
Copy link
Member

Yes please!

@dhomeier
Copy link
Contributor Author

All passing!

@astrofrog astrofrog merged commit 4b01ada into glue-viz:main Feb 25, 2024
21 checks passed
@dhomeier dhomeier changed the title Add Python 3.11 CI env Add Python 3.11 and 3.12 CI envs Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Skipped in Changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants