Merge pull request #2392 from gluestack/feat/snapPoints

fix: added note of snapPoints for select and actionsheet components
gluestack · Aug 21, 2024 · 104f351 · 104f351
2 parents c7fd725 + 8c4304a
commit 104f351
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/example/storybook-nativewind/src/components/Actionsheet/index.nw.stories.mdx b/example/storybook-nativewind/src/components/Actionsheet/index.nw.stories.mdx
@@ -440,6 +440,8 @@ It inherits all the properties of React Native's [View](https://reactnative.dev/
   </TableContainer>
 </>
 
+> Note: If **snapPoints** are not provided to `Actionsheet`, then it's essential to set **maxHeight** to `ActionsheetContent`.
+
 #### ActionsheetBackdrop
 
 It is React Native's [Pressable](https://reactnative.dev/docs/pressable) component, created using [@legendapp/motion's](https://legendapp.com/open-source/motion/) `createMotionAnimatedComponent` function to add animation to the component. You can use any declarative animation library you prefer.

diff --git a/example/storybook-nativewind/src/components/Select/index.nw.stories.mdx b/example/storybook-nativewind/src/components/Select/index.nw.stories.mdx
@@ -461,6 +461,8 @@ It inherits all the properties of React Native's [Pressable](https://reactnative
 
 It is internally mapped wth gluestack-ui's [Actionsheet](/ui/docs/components/disclosure/actionsheet) component, which inherits all the properties of React Native's [View](https://reactnative.dev/docs/view) component.
 
+> Note: If **snapPoints** are not provided to `SelectPortal`, then it's essential to set **maxHeight** to `SelectContent`.
+
 #### SelectBackdrop
 
 It is internally mapped wth gluestack-ui's [ActionsheetBackdrop](https://ui.gluestack.io/docs/components/disclosure/actionsheet) component, which is React Native's [Pressable](https://reactnative.dev/docs/pressable) component, created using [@legendapp/motion's](https://legendapp.com/open-source/motion/) `createMotionAnimatedComponent` function to add animation to the component. You can use any declarative animation library you prefer.