Merge pull request #2403 from sasha-evidation/icons-allow-overriding-…

…role feat: allow overriding of role prop for icons
gluestack · Aug 23, 2024 · 1b9084c · 1b9084c
2 parents acf2372 + c18e7a6
commit 1b9084c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/unstyled/icon/src/createIcon/index.tsx b/packages/unstyled/icon/src/createIcon/index.tsx
@@ -65,7 +65,12 @@ export function createIcon<IconProps>({
       ...props,
     };
 
-    const { stroke = 'currentColor', color, ...resolvedProps } = finalProps;
+    const {
+      stroke = 'currentColor',
+      color,
+      role = 'img',
+      ...resolvedProps
+    } = finalProps;
     let type = resolvedProps.type;
     if (type === undefined) {
       type = 'svg';
@@ -93,7 +98,7 @@ export function createIcon<IconProps>({
       <Root
         {...resolvedProps}
         {...colorProps}
-        role="img"
+        role={role}
         ref={ref}
         {...sizeProps}
         {...sizeStyle}

diff --git a/packages/unstyled/icon/src/createIcon/index.web.tsx b/packages/unstyled/icon/src/createIcon/index.web.tsx
@@ -64,7 +64,12 @@ export function createIcon<IconProps>({
       ...props,
     };
 
-    const { stroke = 'currentColor', color, ...resolvedProps } = finalProps;
+    const {
+      stroke = 'currentColor',
+      color,
+      role = 'img',
+      ...resolvedProps
+    } = finalProps;
     let type = resolvedProps.type;
     if (type === undefined) {
       type = 'svg';
@@ -92,7 +97,7 @@ export function createIcon<IconProps>({
       <Root
         {...resolvedProps}
         {...colorProps}
-        role="img"
+        role={role}
         ref={ref}
         {...sizeProps}
         {...sizeStyle}