Skip to content

Commit

Permalink
fix: config resolution in StyledProvider
Browse files Browse the repository at this point in the history
  • Loading branch information
Suraj authored and Suraj committed Jan 10, 2024
1 parent 4c3b10a commit 8f03c5f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
7 changes: 6 additions & 1 deletion packages/styled/react/src/StyledProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { createGlobalStyles } from './createGlobalStyles';
import { injectGlobalCssStyle } from './injectInStyle';
import { ThemeContext, useTheme } from './Theme';
import { useSafeLayoutEffect } from './hooks/useSafeLayoutEffect';
import { resolveThemes } from './createConfig';

type Config = any;
let colorModeSet = false;
Expand Down Expand Up @@ -75,7 +76,7 @@ export const StyledProvider: React.FC<{
inlineStyleMap.current.initialStyleInjected = false;
// const id = React.useId();
const currentConfig: any = React.useMemo(() => {
const configWithPlatformSpecificUnits: any = platformSpecificSpaceUnits(
let configWithPlatformSpecificUnits: any = platformSpecificSpaceUnits(
config,
Platform.OS
);
Expand All @@ -89,6 +90,10 @@ export const StyledProvider: React.FC<{
Platform.OS
).tokens;
});

configWithPlatformSpecificUnits = resolveThemes(
configWithPlatformSpecificUnits
);
}

return configWithPlatformSpecificUnits;
Expand Down
10 changes: 5 additions & 5 deletions packages/styled/react/src/createConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ export const createConfig = <
// newConfig = resolveComponentThemes(config);
// }

if (config.themes) {
const newConfigWithThemesResolved = resolveThemes(config);
return newConfigWithThemesResolved as any;
}
// if (config.themes) {
// const newConfigWithThemesResolved = resolveThemes(config);
// return newConfigWithThemesResolved as any;
// }
return config as any;
};

const resolveThemes = (config: any) => {
export const resolveThemes = (config: any) => {
function removeDollarSign(obj: any) {
const newObj: any = {};
for (const key in obj) {
Expand Down

0 comments on commit 8f03c5f

Please sign in to comment.