Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-1345: Migrate from azure to linode for runtime-upgrade #1780

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Feb 4, 2025

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov force-pushed the ci/CSUB-1345-migrate-from-azure-to-linode branch from e9014ee to 46c8524 Compare February 4, 2025 10:15
Copy link

github-actions bot commented Feb 4, 2025

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the ci/CSUB-1345-migrate-from-azure-to-linode branch 6 times, most recently from 1b76d77 to e3d8226 Compare February 4, 2025 13:43
@atodorov
Copy link
Contributor Author

atodorov commented Feb 4, 2025

An example execution with the self-hosted runner being provisioned on Linode instead of Azure:
https://github.com/gluwa/creditcoin/actions/runs/13136829697/job/36655179337?pr=1780

@atodorov atodorov changed the base branch from testnet to dev February 4, 2025 14:37
@atodorov atodorov force-pushed the ci/CSUB-1345-migrate-from-azure-to-linode branch from e3d8226 to 0f653c4 Compare February 4, 2025 14:38
@atodorov atodorov marked this pull request as ready for review February 4, 2025 14:39
@beqaabu
Copy link
Contributor

beqaabu commented Feb 4, 2025

unrelated to this but clippy is failing with a ton of errors https://github.com/gluwa/creditcoin/actions/runs/13137923505/job/36657676702?pr=1780

@atodorov
Copy link
Contributor Author

atodorov commented Feb 4, 2025

unrelated to this but clippy is failing with a ton of errors

That's actually been failing since last month and looks like a development dependency has changed underneath. Solving it will probably require updating the operating system and maybe rustc.

@atodorov atodorov merged commit 985812f into dev Feb 5, 2025
32 of 38 checks passed
@atodorov atodorov deleted the ci/CSUB-1345-migrate-from-azure-to-linode branch February 5, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants