Release: 2024.04.04 Subwallet Mobile Support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTES: - removing execution of this job from main/dev branches because we're not building docker images automatically from them
which activates the CreditcoinLocal network in the menu, which in turn enables testing the PR preview build with a locally running creditcoin3-node
in order to make it more explicit that the preview build can be used for early testing as well.
b/c we still want to see the sanity docker build (and whetever sanity tests we may add in the future) succeeding after a PR has been merged. Conditionally skip preview builds and uploads to Azure because they are valid only in the context of a pull request!
because I want to adjust the conditionals later
for PRs against `main` we still want to have the preview functionality. however a "development" build is not the same as a "production" build so we don't want to take the risk and do that! To elaborate, "the risk" is that we build a development preview build, maybe test it directly from the PR preview URL, instead of building it locally and then declaring it PASS, while in reality a production build may be failing! IMO the above mentioned risk is extremely small in practice, however in theory it isn't zero! This change renders the PR preview build impossible to connect to the CreditcoinLocal network which eliminates the risk of testing one thing but shipping another! The inconvenience is that any testing on PRs against `main` branch will require also testing against Devnet (or Testnet, or Mainnet)!
* [SS-457] Connect - order of web wallets doesn't match Gluwa's preferences * [SS-456] Removed hardware wallet option * [SS-454] Remove extra links in Resources view * [SS-453] Remove hardware wallet link on resources view * [SS-453][SS-446] Remove Language, Theme icon on footer
It turns out that we need NODE_ENV='development' is we want to use `vite build`. Otherwise the CreditcoinLocal network doesn't show in the preview build!
This reverts commit c461333.
because they choke on almost everything which is source code and report too many false positive
again, too many false positives
because our releases aren't automated in the same way as upstream
- replace with their current equivalent or - remove entirely if referenced file not found
it is full with broken URLs and we should keep our own changelog anyway
there is `yarn lint` which is executed as part of another CI job that takes care of this
and the opposing formats will cause builds to fail in CI
this is only used for a global installation of yarn inside the build environment. The application itself pins dependencies versions via package.json & yarn.lock files
this is something that came from upstream anyway Finding: const BoardToken = 'REDACTED' Secret: REDACTED RuleID: generic-api-key Entropy: 3.662573 File: src/pages/explore/Feedback.tsx Line: 10 Commit: 134962d Author: Ross Bulat Email: [email protected] Date: 2022-04-25T06:06:04Z Fingerprint: 134962d:src/pages/explore/Feedback.tsx:generic-api-key:10
Co-authored-by: Frank Li <[email protected]>
* [SS-488] [CC3 Dashboard]Remove '(Coming Soon)' phrase.
* feat: Network list by env * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: Added testnet env file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * changes to make test image for test environment, prod image that only has cc3 testnet * fix: Update order * fixed dockerfiles * fix: Default Network * fix: env back * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: yarn build * fix: Lint * fix: Lint * fix: reverse yarn lock * fix: update yarn lock * fix: by node v21 --------- Co-authored-by: Frank Li <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Thomas McDonald <[email protected]>
* [SS-499] Fix subscan button * remove test codes
* [SS-499] Fix subscan button * remove test codes * [SS-499] Fix validator address link
* [SS-499] Fix subscan button * remove test codes * [SS-499] Fix validator address link * [SS-499] change subscan url
* Revert "feat: Network list by env (#79)" This reverts commit 3482a7d. * fix: odometer * docker ci --------- Co-authored-by: Frank Li <[email protected]>
* fix: Validator community * feat: Added dev --------- Co-authored-by: Frank Li <[email protected]>
* [SS-501] Move Odometer component to separate module * Fix some code * Fix some decimal logic with Odometer --------- Co-authored-by: chulhyun.park <[email protected]>
* separate code division on logo area * Change logo to svg * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* [SS-504] fix not working search in validators * Revert link fixing
* [SS-500] [CC3 Dashboard]Favicon image change request * [SS-500] remove the svg favicon
…ific environment (#97) * fix: Change networks by environment * smarter use of docker file * fixing github action as well * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * azdo ci fix * proper way to reference var * fix * build and push have to be seperated * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fux * fix: Remove duplicated build options * fix: staging = prod * fix: yarn build --------- Co-authored-by: Frank Li <[email protected]> Co-authored-by: Thomas McDonald <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix: Subscan api updated * fix: remove last character * fix: Update explorer * fix: Use proxy --------- Co-authored-by: Frank Li <[email protected]>
* fix: Logo as black * fix: Logo --------- Co-authored-by: Frank Li <[email protected]>
Co-authored-by: Frank Li <[email protected]>
Co-authored-by: Frank Li <[email protected]>
…oinTest (#120) * fix: Remove Creditcoin in network list * fix: environment prod --------- Co-authored-by: Frank Li <[email protected]>
…123) * fix: Reset all filters by default * chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Frank Li <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Test before merge -> Staking Dashboad Preview! |
atodorov
requested changes
Apr 5, 2024
| @@ -12,12 +12,12 @@ | |||
| name: 'CodeQL' | |||
|
|
|||
| on: | |||
| push: | |||
| branches: ['dev'] | |||
| pull_request: | |||
| # The branches below must be a subset of the branches above | |||
| branches: ['dev'] | |||
There was a problem hiding this comment.
This needs to include the main branch otherwise a required CI job is not being executed.
Similar for MegaLinter too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.