CSUB-1116: Fetching Member List.... is shown on Members tab when pool member is 0 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test before merge -> Staking Dashboad Preview! |
|
I have reviewed the changes and potential impact by manually creating a pool PoolMemberBecomes1AfterCreating.mov |
Abas-Tim
approved these changes
Apr 11, 2024
atodorov
added a commit
that referenced
this pull request
Apr 19, 2024
This reverts commit bc5ed64 from the original #140 because it is not necessary! The failures are with the markdown-link-check linter which is not influenced by the .lycheeignore config file as seen in the logs for the original commit: https://github.com/gluwa/creditcoin3-staking-dashboard/actions/runs/8744452909/job/23997350187 ^^^ no failures reported by Lychee here
atodorov
added a commit
that referenced
this pull request
Apr 19, 2024
This reverts commits f00f6e0, 8a446ac, b146e14 from the original #140 A better way to fix this is by providing a config file and ignoring the URL in question as shown at https://github.com/tcort/markdown-link-check?tab=readme-ov-file#config-file-format
atodorov
added a commit
that referenced
this pull request
Apr 29, 2024
This reverts commit bc5ed64 from the original #140 because it is not necessary! The failures are with the markdown-link-check linter which is not influenced by the .lycheeignore config file as seen in the logs for the original commit: https://github.com/gluwa/creditcoin3-staking-dashboard/actions/runs/8744452909/job/23997350187 ^^^ no failures reported by Lychee here
atodorov
added a commit
that referenced
this pull request
Apr 29, 2024
This reverts commits f00f6e0, 8a446ac, b146e14 from the original #140 A better way to fix this is by providing a config file and ignoring the URL in question as shown at https://github.com/tcort/markdown-link-check?tab=readme-ov-file#config-file-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.