Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-932: Actually fail CI if yarn lint makes any changes #29

Merged
merged 2 commits into from
Dec 5, 2023
Merged

CSUB-932: Actually fail CI if yarn lint makes any changes #29

merged 2 commits into from
Dec 5, 2023

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Dec 5, 2023

the way yarn lint is designed upstream it will automatically apply changes by eslint & reformat the source code but will always exit with zero.

@atodorov
Actually fail CI if yarn lint makes any changes
660073d 
the way `yarn lint` is designed upstream it will automatically apply
changes by eslint & reformat the source code but will always exit with
zero.
@atodorov
Copy link
Contributor Author

atodorov commented Dec 5, 2023

FTR failing job: https://github.com/gluwa/creditcoin3-staking-dashboard/actions/runs/7098721385/job/19321244440?pr=29

@atodorov atodorov merged commit e5a01f3 into dev Dec 5, 2023
7 of 8 checks passed
@atodorov atodorov deleted the testing/CSUB-932-yarn-lint branch December 5, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atodorov