CSUB-946 wrong pending rewards calculation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test before merge -> Staking Dashboad Preview! |
atodorov
requested changes
Dec 20, 2023
frankli-dev
changed the title
zacharyfrederick
approved these changes
Jan 8, 2024
atodorov
reviewed
Jan 9, 2024
src/contexts/Payouts/defaults.ts
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import type { PayoutsContextInterface } from './types'; | |||
|
|
|||
| export const MaxSupportedPayoutEras = 7; | |||
| export const MaxSupportedPayoutEras = 84; | |||
There was a problem hiding this comment.
After a full 84 eras Polkadot JS Apps and Staking Dashboard seem to be in agreement about the total payouts:
However reloading the page results in 2 possible cases:
- Takes over 5 seconds to load, usually results in this console error:
- If I reload the page again sometimes it doesn't show the error and the reward number is displayed in the matter of 1-2 seconds after displaying the rest of the page.
atodorov
force-pushed
the
fix/increase-max-payout-era
branch
from
77764dd to
fa1bda9
Compare
atodorov
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
With the defaults of max 7 eras to claimed it looks good to me.
Pending rewards amount is in sync with Polkadot JS Apps.
Note: as soon as we have rewards from eras older than current_era - 7, they cannot be claimed via Staking Dashboard but can still be claimed via Polkadot JS Apps. This how Staking Dashboard is designed to work !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
MaxSupportedPayoutErasto 84.One important thing is to clear the browser local storage before restart the chain and run the dashboard.
If it is not cleared, then the calculation will include the previous chain's values.