CSUB-1019 Change the staking dashboard "waiting" label on the Validator page to Active + number #72
Conversation
|
Test before merge -> Staking Dashboad Preview! |
There was a problem hiding this comment.
This is how it looks with only 1 validator - Alice:
This is how the dashboard looks with another validator added (1 era elapsed after adding it), which is still not in the list of active validators:
Note that by default this page has an "Active validators" filter applied to it, and even when clearing the filter the second validator doesn't always show up:
There was a problem hiding this comment.
Review & test round #2
✔️ Validators are shown with the label "Active / X CTC":
✔️ A second validator which has indicated their desire to validate, but is still waiting for the current era to elapse (and possible be selected in the validator set) is also shown as soon as they are chosen as part of the active validation set:
❗ Clicking the "Clear" button doesn't seem to affect anything IMO. I have no idea how it is supposed to work and digging through the code to find that out seems like too much effort in the context of this ticket.
✔️ Having nominators articipate in the mix increases the amount of CTC shown as soon as these nominations become active.
❌ The CTC amount shown does not always sync properly and sometimes it shows "0 CTC". The easiest way to reproduce that is to refresh the page several times subsequently. It is probably unrelated to these actual changes.
|
@atodorov I've fixed the last error the above. (0 CTC sometimes error) |
frankli-dev
force-pushed
the
fix/csub-1019-waiting
branch
2 times, most recently
from
385eb06 to
979dd31
Compare
|
Also fixed the filter. |
frankli-dev
force-pushed
the
fix/csub-1019-waiting
branch
from
3e37a8b to
05639ae
Compare
🟢 : Clicking the "Clear" button while Bob is still not in the active validator set now works for me.
❌ ^^^ during the time in which Bob hasn't made it into the active validator set he is shown as "Active / 0 CTC", see screenshot.
🟢 this seems to have been fixed. |
frankli-dev
force-pushed
the
fix/csub-1019-waiting
branch
from
05639ae to
758bac5
Compare
…or page to Active + number (#72) * fix: Zero era status * fix: Not in this branch * fix: Remove waiting on era status * fix: Show validators even they don't have nominators * fix: Update component on total stake change * fix: Clear filter --------- Co-authored-by: Frank Li <frank.li@gluwa.com>
…or page to Active + number (#72) * fix: Zero era status * fix: Not in this branch * fix: Remove waiting on era status * fix: Show validators even they don't have nominators * fix: Update component on total stake change * fix: Clear filter --------- Co-authored-by: Frank Li <frank.li@gluwa.com>
No description provided.