Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "CI mode" with reduced runtime for double-loop notebooks #159

Open
lbianchi-lbl opened this issue Oct 31, 2022 · 3 comments
Open
Assignees
Labels
Priority:Normal Medium Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

  • Currently, DL notebooks have a runtime that's too long to be run in CI
  • We want to have a programmatic way to be able to set the simulation parameters programmatically so that the runtime is lower if a condition is met (e.g. myparam = 1 if running_in_ci else 10)
  • This mechanism has already been implemented for the RE DL notebook, with the final setup being worked on in Update notebook checks #158
  • We want to have a similar mechanism for the DL notebooks for the remaining case studies
@lbianchi-lbl
Copy link
Contributor Author

We should revisit this when we adapt the DL-using code to the changes due to the new structure of the grid_integration package.

@ksbeattie ksbeattie added Priority:Normal Medium Priority Issue or PR and removed Priority:High High Priority Issue or PR labels Feb 27, 2023
@ksbeattie
Copy link
Contributor

This is here to remind us that we should apply this to other notebooks (when we have time)

@lbianchi-lbl
Copy link
Contributor Author

lbianchi-lbl commented May 22, 2023

Still no updates on this. Not sure if this'll make it to the June release, although it might be connected with #200 and possibly the intermittent failures observed in notebook CI checks on Windows in #142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Medium Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

2 participants