Preserve multiline prompt on 'clear buffer' gnachman/iterm2#1330 #249
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/VT100Grid.m
Outdated
| if (preserveCursorLine) { | ||
| numLinesToScroll = cursor_.y; | ||
| if (preservePromptLines > 0) { | ||
| numLinesToScroll = cursor_.y - preservePromptLines + 1; |
There was a problem hiding this comment.
Must ensure this does not go negative. MAX(0, cursor_.y - preservePromptLines + 1).
dreadatour
force-pushed
the
preserve-multiline-prompt-on-clear-buffer
branch
2 times, most recently
from
a2d8d6d
to
771f93d
Compare
dreadatour
force-pushed
the
preserve-multiline-prompt-on-clear-buffer
branch
from
771f93d
to
8cf13fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Clear Buffer" clears all output except last line, which supposed to be a command prompt. But prompt can consist of more then one line. It would be great to set number of lines that isn't clear by "Clear Buffer".
https://gitlab.com/gnachman/iterm2/issues/1330