fix: ipv6/4 detection - cater for internal layout always being 16 bytes

cmd/root.go

@@ -60,7 +60,7 @@ func init() {
 	rootCmd.PersistentFlags().StringVar(&adminUser, "user", "", "admin_user if any configured in rippled config")
 	rootCmd.PersistentFlags().StringVar(&adminPassword, "passwd", "", "admin_password if any configured in rippled config")
 	rootCmd.PersistentFlags().BoolVarP(&useTls, "tls", "t", false, "use wss scheme, omitting this flag assumes running on localhost")
-	rootCmd.PersistentFlags().StringVarP(&minVersion, "minver", "m", "1.2.3", "Minimum version number acceptable to avoid the ban hammer.")
+	rootCmd.PersistentFlags().StringVarP(&minVersion, "minver", "m", "1.2.4", "Minimum version number acceptable to avoid the ban hammer.")
 	viper.BindPFlag("addr", rootCmd.PersistentFlags().Lookup("addr"))
 	viper.BindPFlag("port", rootCmd.PersistentFlags().Lookup("port"))
 	viper.BindPFlag("user", rootCmd.PersistentFlags().Lookup("user"))

cmd/show.go

@@ -130,12 +130,12 @@ func show(args []string) {
 	table.SetHeader([]string{"IP", "Status", "Version", "Uptime", "Latency", "Load", "Public Key"})
 
 	for _, peer := range peers {
-		if peer.Sanity == "" {
-			peer.Sanity = xrpl.Good
-		}
 		if peer.TooOld() {
 			peer.Sanity = xrpl.Old
 		}
+		if peer.Sanity == "" {
+			peer.Sanity = xrpl.Good
+		}
 		line := lineFromPeer(peer)
 
 		if arg == argCandidates {

firewall/firewalld.go

@@ -66,7 +66,7 @@ func newRejectRule(ip string, timeout int) (*rejectRule, error) {
 	}
 
 	family := "ipv4"
-	if IP.To16() != nil {
+	if IP.To4() == nil {
 		family = "ipv6"
 	}
 
@@ -94,7 +94,7 @@ func newDropRule(ip string, timeout int) (*dropRule, error) {
 	}
 
 	family := "ipv4"
-	if IP.To16() != nil {
+	if IP.To4() == nil {
 		family = "ipv6"
 	}
 

goreleaser.yml

@@ -64,7 +64,7 @@ builds:
     hooks:
 
 sign:
-   artifacts: checksum
+   artifacts: none
 
 # Archive customization
 archive: