-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming pretty printing utilities #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c70975
to
1f10182
Compare
It is inspired by the paper _Lazy v. Yield: Incremental, Linear Pretty-printing_ by Oleg Kiselyov, Simon Peyton-Jones, and Amr Sabry. It adds indentation and alignment features to be useful in the context of streaming tree structure pretty printing (XML, JSON, ...). Any type that has an instance of `Renderable` can be printed. The printer guarantees that the data is printed as early as possible and the it is correct up to the first malformed tree structure.
ybasket
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions and nitpicks, but overall, things look good 👍
Co-authored-by: Yannick Heiber <[email protected]>
ybasket
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is inspired by the paper Lazy v. Yield: Incremental, Linear Pretty-printing by Oleg Kiselyov, Simon Peyton-Jones, and Amr Sabry.
It adds indentation and alignment features to be useful in the context of streaming tree structure pretty printing (XML, JSON, ...).
Any type that has an instance of
Renderable
can be printed.The printer guarantees that the data is printed as early as possible and the it is correct up to the first malformed tree structure.