Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sign addpkg with empty deposit #94

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

luciorubeens
Copy link
Member

Signing a transaction with a empty deposit field causes the following error:

const msg = MsgAddPackage.create({
  deposit: "",
  package: MemPackage.create({
    name: "hello",
    path: "gno.land/r/demo/hello",
    files: [
		// ...
    ],
  }),
});
 log: '--= Error =--\n' +
'Data: std.UnauthorizedError{abciError:std.abciError{}}\n' +
'Msg Traces:\n' +
'    0  /opt/build/pkgs/std/errors.go:70 - signature verification failed; verify correct account sequence and chain-id\n' +
'Stack Trace:\n' +
'    0  /opt/build/pkgs/errors/errors.go:20\n' 

Kudos to the Onbloc team for quickly identifying the issue.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch 💯

Thank you for adding the fix 🙏
I'll merge it in, and do a release so it's live

@zivkovicmilos zivkovicmilos merged commit 90e853d into gnolang:main Mar 11, 2024
2 checks passed
@zivkovicmilos
Copy link
Member

zivkovicmilos commented Mar 11, 2024

Published as the package version to NPM as 1.2.1
@luciorubeens @jinoosss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants