-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add r/grc20reg #2516
base: master
Are you sure you want to change the base?
feat: add r/grc20reg #2516
Conversation
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2516 +/- ##
==========================================
- Coverage 63.79% 63.78% -0.01%
==========================================
Files 549 549
Lines 78819 78781 -38
==========================================
- Hits 50281 50254 -27
+ Misses 25146 25140 -6
+ Partials 3392 3387 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Blocked by #2743 |
Extracted from #2551 (also #2516). <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: moul <[email protected]> Co-authored-by: Morgan <[email protected]>
First of all, I know that this pr is sill working in progress, but couldn't wait for charming of supporting multiple grc20 tokens by default in gno-eco system(in this case Currently, On the other hand, testing with txtar slightly returns different result, |
Yes, this grc20reg is no longer a work in progress, but it depends on the changes in the PR, specifically those in #2743. For a preview of fully working examples, you can check my meta PR #2551, which includes some VM fixes, this completed realm, and other realms that use it, such as the |
Depends on #2743
Continues #1072
Related #1275, #1262
Depends on #1257
Depends on #2551
Alternative to #3135