Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): hall of fame #2842

Merged
merged 95 commits into from
Nov 14, 2024
Merged

feat(examples): hall of fame #2842

merged 95 commits into from
Nov 14, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Sep 24, 2024

Description

Depends on #2584 for avlpager

Introduces the r/demo/hof realm.

The Hall of Fame is an exhibition that holds items. Users can add their realms to the Hall of Fame by importing the Hall of Fame realm and calling hof.Register() from their init function.

The realm is moderated and the registrations be paused at will.

Screenshot 2024-10-07 at 20 09 43

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn self-assigned this Sep 24, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 24, 2024
@leohhhn leohhhn linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (bd1d76e) to head (e79020a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
- Coverage   63.79%   63.76%   -0.03%     
==========================================
  Files         549      548       -1     
  Lines       78819    78674     -145     
==========================================
- Hits        50279    50164     -115     
+ Misses      25150    25128      -22     
+ Partials     3390     3382       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/gno.land/p/demo/fqname/fqname_test.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/ownable/ownable.gno Show resolved Hide resolved
examples/gno.land/r/demo/hof/hof.gno Show resolved Hide resolved
examples/gno.land/r/demo/hof/hof.gno Show resolved Hide resolved
examples/gno.land/r/demo/hof/hof.gno Show resolved Hide resolved
examples/gno.land/r/demo/hof/hof_test.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/hof/hof_test.gno Show resolved Hide resolved
examples/gno.land/r/demo/hof/rendering.gno Outdated Show resolved Hide resolved
@leohhhn leohhhn requested a review from moul November 12, 2024 12:50
@leohhhn leohhhn merged commit 1993c69 into gnolang:master Nov 14, 2024
45 of 60 checks passed
@leohhhn leohhhn deleted the hof branch November 14, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

"home of fame", an hall of fame for homepages.
5 participants