feat: refactor valopers to remove r/sys/validators dependency

[D4ryl00]

fixes #3567

Process to be a validator:

1. Register your validator node as a Valoper. You should fill out the question fields in the /r/gnoland/valopers.Valoper structure.
2. Make a GovDao proposal to add you to the validator valset (/r/sys/validators/v2).
3. The Dao members vote.
4. After acceptance, the proposal must be executed to be effective.

This is a script to help you to test the whole flow with the test1 gnokey key.

#!/bin/sh -x

cat >register_valoper.gno <<END
package main

import (
	"std"

	"gno.land/r/gnoland/valopers"
)

func main() {
	valoper := valopers.Valoper{
		Name:        "berty",
		Description: "Berty's validator",
		ProfileAddress: "g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5",
		OtherNetworks: "no other networks",
		DigitalPresence: "https://berty.tech, https://twitter.com/berty, https://crpt.fyi/berty-discord, https://github.com/berty, https://medium.com/berty-tech, https://www.linkedin.com/company/berty",
		AssetsManagement: "",
		ValidatingInterest: "help to decentralize the network",
		Contributions: "https://github.com/gnolang/hackerspace/issues/28, https://github.com/gnolang/hackerspace/issues/51, https://github.com/gnolang/hackerspace/issues/92",
		Address:     std.Address("g1ut590acnamvhkrh4qz6dz9zt9e3hyu499u0gvl"),
		PubKey:      "gpub1pggj7ard9eg82cjtv4u52epjx56nzwgjyg9zq2gncppkfzmx7s22mn60mf0uxzzpl23yx97hwmwm8yc6lupepqqnlexfch",
		Active:      true,
	}

	valopers.Register(valoper)
}
END

cat >vote_proposal.gno <<END
package main

import (
	"gno.land/r/gov/dao/bridge"
)

func main() {
  bridge.GovDAO().VoteOnProposal(0, "YES")
}
END

cat >execute_proposal.gno <<END
package main

import (
	"gno.land/r/gov/dao/bridge"
)

func main() {
  bridge.GovDAO().ExecuteProposal(0)
}
END

gnokey maketx run \
  -gas-fee 1000000ugnot \
  -gas-wanted 20000000 \
  -broadcast \
  -chainid dev \
  -remote "tcp://127.0.0.1:26657" \
  test1 ./register_valoper.gno

gnokey maketx call \
  -pkgpath "gno.land/r/gnoland/valoper_dao_proposal" \
  -func "MakeProposal" \
  -gas-fee 1000000ugnot \
  -gas-wanted 20000000 \
  -broadcast \
  -chainid "dev" \
  -args "g1ut590acnamvhkrh4qz6dz9zt9e3hyu499u0gvl" \
  -send "100000000ugnot" \
  -remote "tcp://127.0.0.1:26657" \
  test1

gnokey maketx run \
  -gas-fee 1000000ugnot \
  -gas-wanted 20000000 \
  -broadcast \
  -chainid dev \
  -remote "tcp://127.0.0.1:26657" \
  test1 ./vote_proposal.gno

gnokey maketx run \
  -gas-fee 1000000ugnot \
  -gas-wanted 20000000 \
  -broadcast \
  -chainid dev \
  -remote "tcp://127.0.0.1:26657" \
  test1 ./execute_proposal.gno

[Gno2D2]

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)
• The pull request description provides enough details

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: D4ryl00/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied
└── 🔴 If
    ├── 🔴 Condition
    │   └── 🔴 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🔴 Else
        └── 🔴 And
            ├── 🟢 This label is applied to pull request: review/triage-pending
            └── 🔴 On no pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

• team core-contributors

[leohhhn]

Why strAddress string and not just std.Address?

[D4ryl00]

To be able to call this function from gnokey CLI directly, e.g.:
gnokey maketx call -pkgpath "gno.land/r/gnoland/valoper_dao_proposal" -func "MakeProposal" -gas-fee 1000000ugnot -gas-wanted 20000000 -broadcast -chainid "dev" -args "g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5" -remote "tcp://127.0.0.1:26657" test1
and so don't need to create a gno file to create a std.Address object and run it with gnokey maketx run....

Do you think it isn't worth it?

[D4ryl00]

proposal.MakeProposal calls simpledao.Propose under the wood. This function requires us to send some coins to succeed.
So if func MakeProposal(strAddress string) as its parameter as a string, we can call it directly with gnokey maketx call -send 100000000 ... instead of having to do 2 steps:

1. Deploy realm with gnokey maketx addpkg ...
2. Call it with gnokey maketx call -send 100000000 ...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!