chore: Remove the unused gRPC server #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft0
force-pushed
the
chore/remove-unused-gRPC-server
branch
from
7df17ff to
b74b5f5
Compare
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
chore/remove-unused-gRPC-server
branch
from
9e086f8 to
0a9e7fb
Compare
jefft0
added a commit
to gnolang/gnonative
that referenced
this pull request
Dec 19, 2024
gnokey-mobile PR gnolang/gnokey-mobile#35 removed the unused gRPC server, since we now use deep links. Importantly, the code to call functions like `gnoNativeService.ClientSignTx` are removed. So we can remove these functions in gnonative. * In the `GnoNativeService` interface and `gnoNativeService` type, remove `ClientGetRemote`, `ClientListKeyInfo` and `ClientSignTx` which were only used by the Gnokey Mobile gRPC server. * In the `Config` and `gnoNativeService` structs, remove `useGnokeyMobile` flag and the code in api.go which does special handling for this flag. * In bridge.go and the related Swift and Kotlin files, remove support for `StartGnokeyMobileService`. This allows us to remove the dependency on `github.com/gnolang/gnokey-mobile/service`, so remove it from go.mod. * Run `make regenerate` which updates files in api/gen/go, including changes for the new buf version. This PR was tested by running `make npm.pack` in the expo folder, installing this package in gnokey-mobile, then testing with dsocial on Android and iOS simulators. (Note that examples/js/react-native/hello has a copies of files from the expo folder. These are out-of-date for recent changes in the API, including this PR. We will do a future PR to update the hello example.) --------- Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, communication between the app and Gnokey Mobile was with gRPC. But now we only use deep links and the gRPC support is dead code, so this PR removes it.
api,serviceandtestfolders.Makefileandgo.mod. Move.tool-versionsinto themobilefolder.(After merging this PR, we'll do a gnonative PR to remove references to gnokey-mobile.)