-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Android build - set java version compatible with Expo 51 (#143)
This PR fixes the build for Android devices using Expo 51. Expo 51 uses React Native 0.74 which uses Java 17 ([see here](https://reactnative.dev/docs/set-up-your-environment?platform=android)): `If you have already installed JDK on your system, we recommend JDK 17. You may encounter problems using higher JDK versions.` The previous version used was Java 18 which created a conflict between the two versions: `Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (17) and 'compileDebugKotlin' (18).` Finally, this PR also removes the native folders and adds them in the .gitignore files because they are automatically created `npx expo run:ios` (or android), following the recommendations of `npx expo-doctor@latest`. Signed-off-by: D4ryl00 <[email protected]>
- Loading branch information
Showing
72 changed files
with
458 additions
and
3,596 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
nodejs 21.7.3 | ||
ruby 3.2.2 | ||
cocoapods 1.15.2 | ||
java openjdk-18.0.1.1 | ||
java openjdk-17.0.2 | ||
yarn 1.22.19 | ||
golang 1.21.7 | ||
buf 1.30.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,3 +33,7 @@ yarn-error.* | |
|
||
# typescript | ||
*.tsbuildinfo | ||
|
||
# native folders | ||
android/ | ||
ios/ |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
61 changes: 0 additions & 61 deletions
61
expo/example/android/app/src/main/java/land/gno/gnonative/example/MainActivity.kt
This file was deleted.
Oops, something went wrong.
55 changes: 0 additions & 55 deletions
55
expo/example/android/app/src/main/java/land/gno/gnonative/example/MainApplication.kt
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-58.4 KB
expo/example/android/app/src/main/res/drawable-hdpi/splashscreen_image.png
Binary file not shown.
Binary file removed
BIN
-58.4 KB
expo/example/android/app/src/main/res/drawable-mdpi/splashscreen_image.png
Binary file not shown.
Binary file removed
BIN
-58.4 KB
expo/example/android/app/src/main/res/drawable-xhdpi/splashscreen_image.png
Binary file not shown.
Binary file removed
BIN
-58.4 KB
expo/example/android/app/src/main/res/drawable-xxhdpi/splashscreen_image.png
Binary file not shown.
Binary file removed
BIN
-58.4 KB
expo/example/android/app/src/main/res/drawable-xxxhdpi/splashscreen_image.png
Binary file not shown.
Oops, something went wrong.