Add script for betting on omen #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis update introduces a new script, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
mypy.iniis excluded by:!**/*.inipyproject.tomlis excluded by:!**/*.toml
Files selected for processing (1)
- scripts/bet_omen.py (1 hunks)
Additional comments: 1
scripts/bet_omen.py (1)
- 85-86: The script initialization is correctly set up to run the
typerapp. No issues found here.
Comment on lines
+17
to
+48
| @app.command() | ||
| def buy( | ||
| amount: str = typer.Option(), | ||
| from_address: str = typer.Option(), | ||
| from_private_key: str = typer.Option(), | ||
| market_id: str = typer.Option(), | ||
| outcome: str = typer.Option(), | ||
| auto_deposit: bool = typer.Option(False), | ||
| ) -> None: | ||
| """ | ||
| Helper script to place a bet on Omen, usage: | ||
|
|
||
| ```bash | ||
| python scripts/bet_omen.py buy \ | ||
| --amount 0.01 \ | ||
| --from-address your-address \ | ||
| --from-private-key your-private-key \ | ||
| --market-id some-market-id \ | ||
| --outcome one-of-the-outcomes | ||
| ``` | ||
|
|
||
| Market ID can be found easily in the URL: https://aiomen.eth.limo/#/0x86376012a5185f484ec33429cadfa00a8052d9d4 | ||
| """ | ||
| market = get_market(market_id) | ||
| omen_buy_outcome_tx( | ||
| amount=xdai_type(amount), | ||
| from_address=verify_address(from_address), | ||
| from_private_key=PrivateKey(from_private_key), | ||
| market=market, | ||
| outcome=outcome, | ||
| auto_deposit=auto_deposit, | ||
| ) |
There was a problem hiding this comment.
The buy function lacks input validation for amount, market_id, and outcome. Ensure inputs are sanitized and validated to prevent injection attacks or errors.
+ if not amount.isdigit():
+ raise ValueError("Amount must be a numeric value.")
+ if not market_id.isalnum():
+ raise ValueError("Market ID must be alphanumeric.")
+ if not outcome.isalnum():
+ raise ValueError("Outcome must be alphanumeric.")Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| @app.command() | |
| def buy( | |
| amount: str = typer.Option(), | |
| from_address: str = typer.Option(), | |
| from_private_key: str = typer.Option(), | |
| market_id: str = typer.Option(), | |
| outcome: str = typer.Option(), | |
| auto_deposit: bool = typer.Option(False), | |
| ) -> None: | |
| """ | |
| Helper script to place a bet on Omen, usage: | |
| ```bash | |
| python scripts/bet_omen.py buy \ | |
| --amount 0.01 \ | |
| --from-address your-address \ | |
| --from-private-key your-private-key \ | |
| --market-id some-market-id \ | |
| --outcome one-of-the-outcomes | |
| ``` | |
| Market ID can be found easily in the URL: https://aiomen.eth.limo/#/0x86376012a5185f484ec33429cadfa00a8052d9d4 | |
| """ | |
| market = get_market(market_id) | |
| omen_buy_outcome_tx( | |
| amount=xdai_type(amount), | |
| from_address=verify_address(from_address), | |
| from_private_key=PrivateKey(from_private_key), | |
| market=market, | |
| outcome=outcome, | |
| auto_deposit=auto_deposit, | |
| ) | |
| @app.command() | |
| def buy( | |
| amount: str = typer.Option(), | |
| from_address: str = typer.Option(), | |
| from_private_key: str = typer.Option(), | |
| market_id: str = typer.Option(), | |
| outcome: str = typer.Option(), | |
| auto_deposit: bool = typer.Option(False), | |
| ) -> None: | |
| """ | |
| Helper script to place a bet on Omen, usage: | |
| ```bash | |
| python scripts/bet_omen.py buy \ | |
| --amount 0.01 \ | |
| --from-address your-address \ | |
| --from-private-key your-private-key \ | |
| --market-id some-market-id \ | |
| --outcome one-of-the-outcomes | |
| ``` | |
| Market ID can be found easily in the URL: https://aiomen.eth.limo/#/0x86376012a5185f484ec33429cadfa00a8052d9d4 | |
| """ | |
| if not amount.isdigit(): | |
| raise ValueError("Amount must be a numeric value.") | |
| if not market_id.isalnum(): | |
| raise ValueError("Market ID must be alphanumeric.") | |
| if not outcome.isalnum(): | |
| raise ValueError("Outcome must be alphanumeric.") | |
| market = get_market(market_id) | |
| omen_buy_outcome_tx( | |
| amount=xdai_type(amount), | |
| from_address=verify_address(from_address), | |
| from_private_key=PrivateKey(from_private_key), | |
| market=market, | |
| outcome=outcome, | |
| auto_deposit=auto_deposit, | |
| ) |
Comment on lines
+51
to
+82
| @app.command() | ||
| def sell( | ||
| amount: str = typer.Option(), | ||
| from_address: str = typer.Option(), | ||
| from_private_key: str = typer.Option(), | ||
| market_id: str = typer.Option(), | ||
| outcome: str = typer.Option(), | ||
| auto_withdraw: bool = typer.Option(False), | ||
| ) -> None: | ||
| """ | ||
| Helper script to sell outcome of an existing bet on Omen, usage: | ||
|
|
||
| ```bash | ||
| python scripts/bet_omen.py sell \ | ||
| --amount 0.01 \ | ||
| --from-address your-address \ | ||
| --from-private-key your-private-key \ | ||
| --market-id some-market-id \ | ||
| --outcome one-of-the-outcomes | ||
| ``` | ||
|
|
||
| Market ID can be found easily in the URL: https://aiomen.eth.limo/#/0x86376012a5185f484ec33429cadfa00a8052d9d4 | ||
| """ | ||
| market = get_market(market_id) | ||
| omen_sell_outcome_tx( | ||
| amount=xdai_type(amount), | ||
| from_address=verify_address(from_address), | ||
| from_private_key=PrivateKey(from_private_key), | ||
| market=market, | ||
| outcome=outcome, | ||
| auto_withdraw=auto_withdraw, | ||
| ) |
There was a problem hiding this comment.
Similar to the buy function, the sell function also lacks input validation for amount, market_id, and outcome. Apply the same input validation here to ensure data integrity and security.
+ if not amount.isdigit():
+ raise ValueError("Amount must be a numeric value.")
+ if not market_id.isalnum():
+ raise ValueError("Market ID must be alphanumeric.")
+ if not outcome.isalnum():
+ raise ValueError("Outcome must be alphanumeric.")Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| @app.command() | |
| def sell( | |
| amount: str = typer.Option(), | |
| from_address: str = typer.Option(), | |
| from_private_key: str = typer.Option(), | |
| market_id: str = typer.Option(), | |
| outcome: str = typer.Option(), | |
| auto_withdraw: bool = typer.Option(False), | |
| ) -> None: | |
| """ | |
| Helper script to sell outcome of an existing bet on Omen, usage: | |
| ```bash | |
| python scripts/bet_omen.py sell \ | |
| --amount 0.01 \ | |
| --from-address your-address \ | |
| --from-private-key your-private-key \ | |
| --market-id some-market-id \ | |
| --outcome one-of-the-outcomes | |
| ``` | |
| Market ID can be found easily in the URL: https://aiomen.eth.limo/#/0x86376012a5185f484ec33429cadfa00a8052d9d4 | |
| """ | |
| market = get_market(market_id) | |
| omen_sell_outcome_tx( | |
| amount=xdai_type(amount), | |
| from_address=verify_address(from_address), | |
| from_private_key=PrivateKey(from_private_key), | |
| market=market, | |
| outcome=outcome, | |
| auto_withdraw=auto_withdraw, | |
| ) | |
| @app.command() | |
| def sell( | |
| amount: str = typer.Option(), | |
| from_address: str = typer.Option(), | |
| from_private_key: str = typer.Option(), | |
| market_id: str = typer.Option(), | |
| outcome: str = typer.Option(), | |
| auto_withdraw: bool = typer.Option(False), | |
| ) -> None: | |
| """ | |
| Helper script to sell outcome of an existing bet on Omen, usage: | |
| ```bash | |
| python scripts/bet_omen.py sell \ | |
| --amount 0.01 \ | |
| --from-address your-address \ | |
| --from-private-key your-private-key \ | |
| --market-id some-market-id \ | |
| --outcome one-of-the-outcomes | |
| ``` | |
| Market ID can be found easily in the URL: https://aiomen.eth.limo/#/0x86376012a5185f484ec33429cadfa00a8052d9d4 | |
| """ | |
| if not amount.isdigit(): | |
| raise ValueError("Amount must be a numeric value.") | |
| if not market_id.isalnum(): | |
| raise ValueError("Market ID must be alphanumeric.") | |
| if not outcome.isalnum(): | |
| raise ValueError("Outcome must be alphanumeric.") | |
| market = get_market(market_id) | |
| omen_sell_outcome_tx( | |
| amount=xdai_type(amount), | |
| from_address=verify_address(from_address), | |
| from_private_key=PrivateKey(from_private_key), | |
| market=market, | |
| outcome=outcome, | |
| auto_withdraw=auto_withdraw, | |
| ) |
evangriffiths
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit