Pass in generic BetAmount to place_bet
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evangriffiths
commented
Feb 6, 2024
| --agent-type [langchain|autogen|always_yes|coin_flip|llamaindex|metagpt|crewai|custom_openai|custom_llama] | ||
| [default: AgentType.ALWAYS_YES] | ||
| --auto-bet / --no-auto-bet [default: no-auto-bet] | ||
| --help Show this message and exit. |
There was a problem hiding this comment.
This is just an update since now main.py uses typer
kongzii
approved these changes
Feb 6, 2024
| --agent-type [langchain|autogen|always_yes|coin_flip|llamaindex|metagpt|crewai|custom_openai|custom_llama] | ||
| [default: AgentType.ALWAYS_YES] | ||
| --auto-bet / --no-auto-bet [default: no-auto-bet] | ||
| --help Show this message and exit. |
| elif market_type == MarketType.MANIFOLD: | ||
| return BetAmount(amount=amount, currency=Currency.Mana) | ||
| else: | ||
| raise ValueError(f"Unknown market type: {market_type}") |
There was a problem hiding this comment.
Simple and cool! Nicer than having N arguments for each currency :-D
Co-authored-by: Peter Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer
place_bettaking a single requiredamountarg, and then handling the conversion to the correct currency, as apposed to taking optionalamounts in all the possible currencies it could support.