-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass in generic BetAmount to place_bet
#23
Conversation
--agent-type [langchain|autogen|always_yes|coin_flip|llamaindex|metagpt|crewai|custom_openai|custom_llama] | ||
[default: AgentType.ALWAYS_YES] | ||
--auto-bet / --no-auto-bet [default: no-auto-bet] | ||
--help Show this message and exit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an update since now main.py
uses typer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
--agent-type [langchain|autogen|always_yes|coin_flip|llamaindex|metagpt|crewai|custom_openai|custom_llama] | ||
[default: AgentType.ALWAYS_YES] | ||
--auto-bet / --no-auto-bet [default: no-auto-bet] | ||
--help Show this message and exit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
elif market_type == MarketType.MANIFOLD: | ||
return BetAmount(amount=amount, currency=Currency.Mana) | ||
else: | ||
raise ValueError(f"Unknown market type: {market_type}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and cool! Nicer than having N arguments for each currency :-D
Co-authored-by: Peter Jung <[email protected]>
I prefer
place_bet
taking a single requiredamount
arg, and then handling the conversion to the correct currency, as apposed to taking optionalamount
s in all the possible currencies it could support.