Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent deployment tooling #24

Merged
merged 15 commits into from
Feb 8, 2024
Merged

Add agent deployment tooling #24

merged 15 commits into from
Feb 8, 2024

Conversation

evangriffiths
Copy link
Contributor

No description provided.

Copy link
Contributor

@kongzii kongzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small tweaks

examples/cloud_deployment/deploy.py Show resolved Hide resolved
prediction_market_agent/data_models/market_data_models.py Outdated Show resolved Hide resolved
prediction_market_agent/deploy/deploy.py Outdated Show resolved Hide resolved
def answer_binary_market(self, market: AgentMarket) -> bool:
raise NotImplementedError("This method should be implemented by the subclass")

def deploy(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method used somewhere? 🤔

Copy link
Contributor Author

@evangriffiths evangriffiths Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's a placeholder for now until we have a nice way of merging deploy_to_gcp into it. For now I've added a pytest

@kongzii
Copy link
Contributor

kongzii commented Feb 8, 2024

Is there a need for the agent.py I created before? Feel free to remove it if not.

@evangriffiths
Copy link
Contributor Author

Is there a need for the agent.py I created before? Feel free to remove it if not.

I guess not, unless we want to keep it here when we pull out the deployment code into the separate repo. I've deleted, but happy to leave in if you prefer.

@evangriffiths evangriffiths merged commit c737ded into main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants