Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetWalletBalance.__call__ args #63

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

evangriffiths
Copy link
Contributor

Added test to ensure call args for all registered functions are correct.

Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

Walkthrough

The update involves enhancing security and functionality within the prediction_market_agent project. Changes include modifying how balances are retrieved and how API keys are accessed, alongside adding new tests for existing market functions to ensure robustness and reliability.

Changes

File Path Change Summary
.../microchain_agent/functions.py Modified __call__ method to use a predefined address for balance.
.../microchain_agent/microchain_agent.py Replaced os.getenv with APIKeys class for secure API key retrieval.
tests/agents/test_microchain.py Added new imports and function registrations in test functions.

Possibly related issues


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a06fb91 and 8fafeec.
Files selected for processing (1)
  • .github/workflows/python_ci.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/python_ci.yaml (1)

10-10: The removal of BET_FROM_ADDRESS appears to be handled correctly in this workflow file as there are no references to it in the steps. Ensure that no other part of the codebase relies on this environment variable.

Verification successful

The search confirmed that BET_FROM_ADDRESS is not used elsewhere in the codebase. The removal of this environment variable from the GitHub Actions workflow is correctly handled and should not cause any issues.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Search for any references to 'BET_FROM_ADDRESS' in the repository.
rg 'BET_FROM_ADDRESS'

Length of output: 21


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -1,13 +1,9 @@
import os
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also using APIKeys here as well (unrelated to the fix)

@evangriffiths evangriffiths merged commit 83ff1be into main Apr 10, 2024
6 checks passed
@evangriffiths evangriffiths deleted the evan/microchain-fix-engine-help branch April 10, 2024 11:57
This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants