Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install extras from PMAT #76

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Install extras from PMAT #76

merged 5 commits into from
Apr 16, 2024

Conversation

kongzii
Copy link
Contributor

@kongzii kongzii commented Apr 15, 2024

Summary by CodeRabbit

  • New Features
    • Updated the prediction-market-agent-tooling dependency to include additional extras like "langchain" and "google" for enhanced functionality.

Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent update enhances the prediction-market-agent-tooling dependency in pyproject.toml by incorporating extras like "langchain" and "google," enriching the tooling's capabilities and compatibility. In think_thoroughly_agent.py, the change involves replacing the .dict() method with .model_dump() in the generate_final_decision function to improve outcome processing with probabilities.

Changes

File Summary of Changes
pyproject.toml Updated prediction-market-agent-tooling in pyproject.toml to include extras "langchain" and "google".
think_thoroughly_agent/think_thoroughly_agent.py Replaced .dict() with .model_dump() in generate_final_decision function for outcome processing.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

pyproject.toml Outdated
@@ -35,7 +35,7 @@ poetry = "^1.7.1"
poetry-plugin-export = "^1.6.0"
functions-framework = "^3.5.0"
cron-validator = "^1.0.8"
prediction-market-agent-tooling = "^0.13.1"
prediction-market-agent-tooling = { version = "^0.13.1", extras = ["langchain", "google"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use extras = ["all"] to save specifying them manually
https://python-poetry.org/docs/pyproject/#extras

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like it should work, but if I do it, it removes them from the lock file:

Screenshot by Dropbox Capture

and after removing and installing the poetry env again, it's not there:

Screenshot by Dropbox Capture

but if I keep it explicit it works:

Screenshot by Dropbox Capture

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yes I get the same. Can't see anything on this from googling. Oh well!

pyproject.toml Outdated
@@ -35,7 +35,7 @@ poetry = "^1.7.1"
poetry-plugin-export = "^1.6.0"
functions-framework = "^3.5.0"
cron-validator = "^1.0.8"
prediction-market-agent-tooling = "^0.13.1"
prediction-market-agent-tooling = { version = "^0.13.1", extras = ["langchain", "google"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yes I get the same. Can't see anything on this from googling. Oh well!

@kongzii kongzii merged commit aea94c0 into main Apr 16, 2024
6 checks passed
@kongzii kongzii deleted the peter/fix branch April 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants