Feature/greco integration #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime center function and tests
|
let's squash the linter errors and make sure all of the tests are passing before merging. |
added 9 commits
February 13, 2025 11:23
|
@auryn-macmillan I managed to squash the linting errors, but I am not sure how to fix the test and coverage error. I believe it has something to do with -Zprofile being an unstable Rust compiler flag and only able to be used with the nightly Rust toolchain? Any guidance on this would be appreciated |
…e source‑based coverage is now stable, switched the toolchain from nightly to stable ಥ_ಥ correct coverage location （；´д｀）ゞ Update Grcov source dir for coverage files /_ \
hmzakhalid
force-pushed
the
feature/greco-integration
branch
from
24b5cb5 to
2406f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR to merge the changes needed for Greco from months ago as well as the prime factorization code for threshold from a couple weeks ago.