Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: gnsmath #489

Merged
merged 4 commits into from
Feb 3, 2025
Merged

refactor: gnsmath #489

merged 4 commits into from
Feb 3, 2025
+381 −344

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jan 31, 2025

Description

  • Removed _helper_test.gno file
  • Refactored SwapMathComputeSwapStepStr function
  • Removed redundant branches

@notJoon notJoon requested review from onlyhyde and r3v4s January 31, 2025 07:40
r3v4s
r3v4s previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notJoon notJoon mentioned this pull request Jan 31, 2025
Draft
onlyhyde
onlyhyde reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@onlyhyde onlyhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring is good. I would like to see some of the function naming changed. I would suggest removing the file name sqrtPriceMath from the function.

@notJoon notJoon requested review from r3v4s and onlyhyde January 31, 2025 09:56
r3v4s
r3v4s suggested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you haven't resolved every request from onlyhyde

onlyhyde
onlyhyde previously approved these changes Feb 2, 2025
View reviewed changes
dongwon8247
dongwon8247 previously approved these changes Feb 3, 2025
View reviewed changes
@r3v4s r3v4s self-requested a review February 3, 2025 07:20
r3v4s
r3v4s previously approved these changes Feb 3, 2025
View reviewed changes
@notJoon notJoon dismissed stale reviews from r3v4s, onlyhyde, and dongwon8247 via cd8136a February 3, 2025 09:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s self-requested a review February 3, 2025 09:37
@notJoon notJoon merged commit 01c3031 into main Feb 3, 2025
18 of 19 checks passed
@notJoon notJoon deleted the gnsmath branch February 3, 2025 09:44
r3v4s pushed a commit that referenced this pull request Feb 4, 2025
@notJoon @dongwon8247 @r3v4s
refactor: gnsmath (#489)
7928bee 
* refactor: gnsmath

---------

Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
onlyhyde pushed a commit that referenced this pull request Feb 5, 2025
@r3v4s @notJoon @dongwon8247
test: txtar based testing (#492)
723e2c7 
* test: txtar deploy testing
* doc (#490)
* GSW-2080 docs: update comments (#488)
* docs: comments, docs, ...
* chore: unify block interval to ms
* chore: milliToSec() to convert milisecond to second
* refactor: gnsmath (#489)
* refactor: gnsmath

Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247

@r3v4s r3v4s

@onlyhyde onlyhyde

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notJoon @onlyhyde @dongwon8247 @r3v4s